[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

kkcode0 updated this revision to Diff 555625. kkcode0 marked an inline comment as done. kkcode0 added a comment. use ptracewrapper Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lld

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

kkcode0 added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:186-193 - -if (!SetRendezvousBreakpoint()) { - // If we cannot establish rendezvous breakpoint right now we'll try again - // at entry point. - P

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

kkcode0 added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:114-117 + tp = LLDB_INVALID_ADDRESS; + Status error; + return error; +} labath wrote: > Is this necessary, given that the function is already stubbed o

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

kkcode0 updated this revision to Diff 92. kkcode0 marked an inline comment as done. kkcode0 added a comment. spacing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/com

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

kkcode0 updated this revision to Diff 91. kkcode0 marked 3 inline comments as done. kkcode0 added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/inclu

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

kkcode0 updated this revision to Diff 75. kkcode0 added a comment. formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h lldb/incl

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

kkcode0 updated this revision to Diff 74. kkcode0 marked an inline comment as done. kkcode0 added a comment. formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

kkcode0 updated this revision to Diff 73. kkcode0 added a comment. formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h lldb/incl

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

kkcode0 updated this revision to Diff 72. kkcode0 added a comment. formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h lldb/incl

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

labath added a comment. There's one thing that's not clear to me about this patch. What is the relationship between `qGetTLSAddr`, as implemented here, and its implementation in GDB? I guess they're not compatible since we're not sending or using the offset and link map fields, but it's not cle

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

kkcode0 added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

kkcode0 updated this revision to Diff 496655. kkcode0 added a comment. added comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h lldb/

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

kkcode0 updated this revision to Diff 496654. kkcode0 added a comment. added comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Target/RegisterContext.h Index: lldb/incl

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

jingham added a comment. A tiny quibble: GetThreadPointer seems like it should return a pointer to the thread that has this register set. I would not guess it's a pointer to the Thread's local storage. Maybe GetThreadLSPointer + a doc string saying what it does would clear this up? Reposito

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

kkcode0 updated this revision to Diff 496392. kkcode0 added a comment. enabled the tls test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h