This revision was automatically updated to reflect the committed changes.
Closed by commit rGb461398f1ce3: Add a new SBDebugger::SetDestroyCallback() API
(authored by yinghuitan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143520/new/
https://rev
yinghuitan updated this revision to Diff 502897.
yinghuitan added a comment.
Address review feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143520/new/
https://reviews.llvm.org/D143520
Files:
lldb/bindings/python/python-typemaps.swig
l
clayborg added a comment.
Just change HandleDestroryCallback to a member function and this is good to go.
Comment at: lldb/source/Core/Debugger.cpp:688-694
+void Debugger::HandleDestroyCallback(const DebuggerSP &debugger_sp) {
+ if (debugger_sp->m_destroy_callback) {
+debu
yinghuitan updated this revision to Diff 497133.
yinghuitan added a comment.
Address review comments by using the same type for internal and
public callbacks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143520/new/
https://reviews.llvm.org/D1435
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
If I am reading the code for this patch correctly, we need the BatonSP stuff
because we have differing callback bytes for public vs private APIs. If we
switch to using a common c
yinghuitan created this revision.
yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere,
kusmour, GeorgeHuyubo.
Herald added a project: All.
yinghuitan requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Adding a new S
