[Lldb-commits] [PATCH] D142150: [lldb] Remove timer from SBModule copy ctor

JDevlieghere added a comment. In D142150#4074015 , @aprantl wrote: > What about adding a `trivial` parameter to the macro that has the effect of > skipping it in instrumentation if the instrumentation is the costly signpost > mechanism? The `_VA` macro

[Lldb-commits] [PATCH] D142150: [lldb] Remove timer from SBModule copy ctor

kastiglione added a comment. In D142150#4074015 , @aprantl wrote: > What about adding a `trivial` parameter to the macro that has the effect of > skipping it in instrumentation if the instrumentation is the costly signpost > mechanism? sounds good to m

[Lldb-commits] [PATCH] D142150: [lldb] Remove timer from SBModule copy ctor

aprantl added a comment. What about adding a `trivial` parameter to the macro that has the effect of skipping it in instrumentation if the instrumentation is the costly signpost mechanism? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142150/new/

[Lldb-commits] [PATCH] D142150: [lldb] Remove timer from SBModule copy ctor

JDevlieghere reopened this revision. JDevlieghere added a comment. There's two issues with this patch: - `LLDB_INSTRUMENT_VA` is not the same as `LLDB_SCOPED_TIMER`. It's used for logging and tracks ABI boundaries. This breaks boundary tracking. - Next time someone runs `lldb-instr` on this file

[Lldb-commits] [PATCH] D142150: [lldb] Remove timer from SBModule copy ctor

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG84c6129c9431: [lldb] Remove timer from SBModule copy ctor (authored by kastiglione). Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D142150: [lldb] Remove timer from SBModule copy ctor

kastiglione created this revision. kastiglione added a reviewer: aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The SBModule copy constructor has fast execution, and is high firing. Fast an