[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

2023-01-27 Thread Alexander Yermolovich via Phabricator via lldb-commits
ayermolo updated this revision to Diff 492842. ayermolo marked an inline comment as done. ayermolo added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139957/new/ https://reviews.llvm.org/D139957 Files: lldb/source/

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

2023-01-27 Thread Alexander Yermolovich via Phabricator via lldb-commits
ayermolo marked 2 inline comments as done. ayermolo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:32 - DIERef(std::optional dwo_num, Section section, + DIERef(std::optional dwo_oso_num, Section section, dw_offset_t die_offset)

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

2023-01-27 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:32 - DIERef(std::optional dwo_num, Section section, + DIERef(std::optional dwo_oso_num, Section section, dw_offset_t die_offset) ayermolo wrote: > labath wrote:

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

2023-01-26 Thread Alexander Yermolovich via Phabricator via lldb-commits
ayermolo marked an inline comment as done. ayermolo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:32 - DIERef(std::optional dwo_num, Section section, + DIERef(std::optional dwo_oso_num, Section section, dw_offset_t die_offset)

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

2023-01-23 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:32 - DIERef(std::optional dwo_num, Section section, + DIERef(std::optional dwo_oso_num, Section section, dw_offset_t die_offset) Where is this constructor being

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

2023-01-20 Thread Alexander Yermolovich via Phabricator via lldb-commits
ayermolo updated this revision to Diff 491009. ayermolo added a comment. Updated based on Gregs suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139957/new/ https://reviews.llvm.org/D139957 Files: lldb/source/Plugins/SymbolFile/DWARF/DI

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

2022-12-13 Thread Alexander Yermolovich via Phabricator via lldb-commits
ayermolo created this revision. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. ayermolo requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Following example of DWO changing it to use DIERef. Depends on D138618