Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

2015-11-04 Thread Ryan Brown via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL252109: Add go data formatters. (authored by ribrdb). Changed prior to commit: http://reviews.llvm.org/D13878?vs=37900&id=39288#toc Repository: rL LLVM http://reviews.llvm.org/D13878 Files: lldb/t

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

2015-10-29 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. I think it's OK to land this, yes I would still like to think about ways that we can avoid using hardcoded formatters here, but it seems non-trivial and I don't know enough abo

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

2015-10-29 Thread Ryan Brown via lldb-commits
ribrdb added a comment. Is this ready to submit? http://reviews.llvm.org/D13878 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

2015-10-20 Thread Ryan Brown via lldb-commits
ribrdb removed rL LLVM as the repository for this revision. ribrdb updated this revision to Diff 37900. ribrdb added a comment. Oops, I ran clang-format with the wrong arguments. Ran it again. http://reviews.llvm.org/D13878 Files: cmake/LLDBDependencies.cmake lldb.xcodeproj/project.pbxproj

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

2015-10-20 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a comment. Did you format code with Clang-format? Spaces/no spaces between function names and arguments are inconsistent. Comment at: source/Plugins/Language/Go/GoFormatterFunctions.h:29 @@ +28,3 @@ + +#include "clang/AST/ASTContext.h" + Th

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

2015-10-20 Thread Ryan Brown via lldb-commits
ribrdb updated this revision to Diff 37898. Repository: rL LLVM http://reviews.llvm.org/D13878 Files: cmake/LLDBDependencies.cmake lldb.xcodeproj/project.pbxproj source/API/SystemInitializerFull.cpp source/Plugins/Language/CMakeLists.txt source/Plugins/Language/Go/CMakeLists.txt so

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

2015-10-20 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added inline comments. Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:10 @@ +9,3 @@ + +#include + ribrdb wrote: > Eugene.Zelenko wrote: > > Please add include section comments. Same for other sections. > Which sections? I've seen a

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

2015-10-20 Thread Ryan Brown via lldb-commits
ribrdb added inline comments. Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:10 @@ +9,3 @@ + +#include + Eugene.Zelenko wrote: > Please add include section comments. Same for other sections. Which sections? I've seen a couple types of section mar

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

2015-10-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added inline comments. Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:107 @@ +106,3 @@ + +} // anonymous namespace + One space should be enough. Repository: rL LLVM http://reviews.llvm.org/D13878 ___

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

2015-10-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a comment. I think will be good idea to format code with Clang-format. See also http://reviews.llvm.org/rL250789 I just committed with similar cleanups for other languages. Repository: rL LLVM http://reviews.llvm.org/D13878 __

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

2015-10-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added inline comments. Comment at: source/Plugins/Language/Go/GoFormatterFunctions.h:1 @@ +1,2 @@ +//===-- GoFormatterFunctions.h*- C++ -*-===// +// Such comments should be 80 characters long. C

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

2015-10-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:10 @@ +9,3 @@ + +#include + Please add include section comments. Same for other sections. Comment at: source/Plugins/Language/Go/G

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

2015-10-19 Thread Enrico Granata via lldb-commits
granata.enrico added inline comments. Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:104 @@ +103,3 @@ +size_t m_len; +std::vector m_children; +}; This worries me a little bit Imagine I have one of these slices with a million elements, and

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

2015-10-19 Thread Greg Clayton via lldb-commits
clayborg resigned from this revision. clayborg edited reviewers, added: granata.enrico; removed: clayborg. clayborg added a comment. Enrico should take a look and OK this. Repository: rL LLVM http://reviews.llvm.org/D13878 ___ lldb-commits mailin

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

2015-10-19 Thread Ryan Brown via lldb-commits
ribrdb updated this revision to Diff 37800. ribrdb added a comment. Add tests. Repository: rL LLVM http://reviews.llvm.org/D13878 Files: cmake/LLDBDependencies.cmake lldb.xcodeproj/project.pbxproj source/API/SystemInitializerFull.cpp source/Plugins/Language/CMakeLists.txt source/Pl

[Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

2015-10-19 Thread Ryan Brown via lldb-commits
ribrdb created this revision. ribrdb added a reviewer: clayborg. ribrdb added a subscriber: lldb-commits. ribrdb set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D13878 Files: cmake/LLDBDependencies.cmake lldb.xcodeproj/project.pbxproj source/A