[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

2022-10-25 Thread jeffrey tan via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG51effa57818b: Fix exception description in lldb-vscode (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136295/new/ https://reviews.l

[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

2022-10-20 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan updated this revision to Diff 469376. yinghuitan added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136295/new/ https://reviews.llvm.org/D136295 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldb

[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

2022-10-20 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan updated this revision to Diff 469374. yinghuitan added a comment. Directly raise signal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136295/new/ https://reviews.llvm.org/D136295 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-

[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

2022-10-20 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. If you're explicitly checking for SIGABRT, then you might as well raise that signal directly (`raise(SIGABRT)`) instead of relying on the runtime to do it (in response to an unhandled exception). Or, if you want this to work on windows, then you'll need to adjust the exp

[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

2022-10-19 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour, fixathon. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There is a