jryans added a comment.
Ah yes, it’s all done now, feel free to clean up your local state however you
prefer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135577/new/
https://reviews.llvm.org/D135577
_
HenriqueBucher added a comment.
I mean my **local** changes, can I consider this done and clean up?
Sorry for the very newbie question.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135577/new/
https://reviews.llvm.org/D135577
___
jryans added a comment.
No, once it has been committed, it can’t really be removed from a project of
this size. Changes can be reverted, but the existence of the commits and
messages remains. Don’t worry about it for this one, just something to think
about next time.
Repository:
rG LLVM Git
HenriqueBucher added a comment.
Is there anything to be done at this point? Can I reset my branch?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135577/new/
https://reviews.llvm.org/D135577
___
lldb-comm
jryans added a comment.
Exciting, welcome to the LLVM community! 🙂
Overall your commit looks okay, but here are a few tips for the future... The
"Summary:" prefix in the commit title is not needed. It's good to start the
commit title with an active verb e.g. "Add foo to bar". You can optionally
HenriqueBucher added a comment.
Got a very nice email from Chris Lattner with the approval. Very nice.
Dude I took the plunge and did it. I hope it went through right. Please let me
know if I screwed it up.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5a52c5c42669: Summary: This documentation patch adds
information to allow remote users to… (authored by HenriqueBucher).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.
HenriqueBucher updated this revision to Diff 467313.
HenriqueBucher retitled this revision from "Summary:" to "Summary: This
documentation patch adds information to allow remote users to also use the
plugin as it will be invisible to them using the current instructions. It
solves issue #58252.".
HenriqueBucher updated this revision to Diff 467310.
HenriqueBucher added a comment.
Visual Studio code has different folders for plugins when used by local users
and users remoting into the box.
The current instructions show how to install the lldb-vscode plugin only for
the local users and it
DavidSpickett added a comment.
Oh and if you would like someone to land this on your behalf please provide a
name and email address for the commit (of course waiting for access is fine
too).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135577/new
DavidSpickett added a comment.
> Note: The reason the summary is so terse is that the ARC tool opens two
> windows and I was very confused about where to write what.
Certainly would confuse me, maybe I've learned to autopilot through this
though. Can you describe them? We can certainly add a no
HenriqueBucher added a comment.
I assume not since I have never committed on any LLVM project.
But I would like to as I plan to contribute more in the future.
Just sent Chris Clattner an email with the request.
Note: The reason the summary is so terse is that the ARC tool opens two windows
and
JDevlieghere added a comment.
Henrique, do you have commit access?
Whoever ends up committing this, please make sure the commit has a reasonable
commit description and not "Summary:".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135577/new/
http
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135577/new/
https://reviews.llvm.org/D135577
___
clayborg added a comment.
lgtm. Jonas?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135577/new/
https://reviews.llvm.org/D135577
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
HenriqueBucher added a comment.
Ok submitted another patch. Added you as reviewer. Check if it is okay.
https://reviews.llvm.org/D135607
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135577/new/
https://reviews.llvm.org/D135577
__
JDevlieghere added inline comments.
Comment at: lldb/tools/lldb-vscode/README.md:39
+It is important to note that the directory `~/.vscode/extensions` works for
users logged in locally to the machine. If you are remoting into the box using
Visual Studio Code's Remote plugins
HenriqueBucher added inline comments.
Comment at: lldb/tools/lldb-vscode/README.md:39
+It is important to note that the directory `~/.vscode/extensions` works for
users logged in locally to the machine. If you are remoting into the box using
Visual Studio Code's Remote plugin
HenriqueBucher updated this revision to Diff 466538.
HenriqueBucher added a comment.
Removed 2 extra blank lines
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135577/new/
https://reviews.llvm.org/D135577
Files:
lldb/tools/lldb-vscode/README.md
HenriqueBucher updated this revision to Diff 466537.
HenriqueBucher added a comment.
Formatted text to wrap in 80 columns
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135577/new/
https://reviews.llvm.org/D135577
Files:
lldb/tools/lldb-vscode/RE
jryans added a comment.
Please also give this patch a title that would make sense as the first line of
a commit message. It currently just says "Summary:" at the moment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135577/new/
https://reviews.llv
JDevlieghere requested changes to this revision.
JDevlieghere added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/tools/lldb-vscode/README.md:39
+It is important to note that the directory `~/.vscode/extensions` works for
users logged in loca
HenriqueBucher created this revision.
HenriqueBucher added a reviewer: clayborg.
Herald added a project: All.
HenriqueBucher requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This documentation patch adds information to allow remote users to
23 matches
Mail list logo
