This revision was automatically updated to reflect the committed changes.
Closed by commit rL249806: Fix handling of LLDB_VERS_GENERATED_FILE. (authored
by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13552?vs=36851&id=36923#toc
Repository:
rL LLVM
http://reviews.llvm.org/D135
dawn accepted this revision.
dawn added a comment.
This revision is now accepted and ready to land.
Works great! Please commit. (Sorry for delay - I ran into problems with clang
crashing on me for unknown reasons - finally got the build working again so I
could test).
http://reviews.llvm.org
dawn added a comment.
Hi Bruce, thanks for this patch! I'll give it a try now...
http://reviews.llvm.org/D13552
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
I'll defer to Dawn, I'm not too familiar with how the CMake Darwin stuff works.
If the people interested say it works, that's fine with me.
http://reviews.llvm.org/D13552
___
lldb-commits mailing list
lldb-commits@lists.ll
brucem added a comment.
Both builds from clean and incremental have now succeeded for me with this
patch.
http://reviews.llvm.org/D13552
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
brucem added a comment.
I have a full build from clean going with this. I'm pretty sure that it will be
fine.
I'll check this into SVN after I wake up if someone agrees that it looks good.
http://reviews.llvm.org/D13552
___
lldb-commits mailing li
brucem added a comment.
I did NOT test this with a full rebuild as it is nearly my bedtime. I did test
it with an incremental build as well as rm'ing the generated file and touching
the (new) dependencies to make sure that the vers file got regenerated.
http://reviews.llvm.org/D13552
__
brucem created this revision.
brucem added reviewers: dawn, sas, clayborg, zturner.
brucem added a subscriber: lldb-commits.
This is Darwin only.
The symbol defined by ${LLDB_VERS_GENERATED_FILE} is used by
source/lldb.cpp, so anything that uses lldb.cpp (which is in
lldbBase) should also have th
