Re: [Lldb-commits] [PATCH] D13506: Remove unused virtuals from ABISysV_ppc*

2015-10-07 Thread Bruce Mitchener via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL249563: Remove unused virtuals from ABISysV_ppc* (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D13506?vs=36726&id=36753#toc Repository: rL LLVM http://reviews.llvm.org/D1350

Re: [Lldb-commits] [PATCH] D13506: Remove unused virtuals from ABISysV_ppc*

2015-10-07 Thread Justin Hibbits via lldb-commits
jhibbits accepted this revision. jhibbits added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D13506#261638, @brucem wrote: > There's nothing to test here short of "Does it compile?" as these functions > aren't actually used anywhere. I'm cleaning out dea

Re: [Lldb-commits] [PATCH] D13506: Remove unused virtuals from ABISysV_ppc*

2015-10-07 Thread Bruce Mitchener via lldb-commits
brucem added a comment. There's nothing to test here short of "Does it compile?" as these functions aren't actually used anywhere. I'm cleaning out dead virtuals in various patches. http://reviews.llvm.org/D13506 ___ lldb-commits mailing list lldb

Re: [Lldb-commits] [PATCH] D13506: Remove unused virtuals from ABISysV_ppc*

2015-10-07 Thread Justin Hibbits via lldb-commits
jhibbits added a comment. Backtraces do work now, for ppc at least (ppc64 IIRC still has issues dealing with the function descriptors, but traversing the backchain does work). I can test this after I get my system set up from my move, but if you've tested it either natively or on a core then I

[Lldb-commits] [PATCH] D13506: Remove unused virtuals from ABISysV_ppc*

2015-10-07 Thread Bruce Mitchener via lldb-commits
brucem created this revision. brucem added reviewers: clayborg, jingham, jhibbits, emaste. brucem added a subscriber: lldb-commits. The StackUsesFrames and FunctionCallsChangeCFA virtual functions aren't used anywhere and aren't overridden by anything. They were introduced when the ABISysV_ppc* c