This revision was automatically updated to reflect the committed changes.
Closed by commit rG852a4bdb25d1: Change the Sanitizer report breakpoint
callbacks to asynchronous. (authored by jingham).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134927/n
jingham updated this revision to Diff 464442.
jingham added a comment.
Handled hitting the sanitizer breakpoint while calling a function in
StopInfoBreakpoint.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134927/new/
https://reviews.llvm.org/D134
jingham added a comment.
I had to fix one other thing. I had arbitrarily made the decision that if an
internal breakpoint was hit while running an expression we should stop before
running its callbacks. At the time we only had internal breakpoints with sync
callbacks (again mostly dynamic loa
JDevlieghere accepted this revision.
JDevlieghere added a comment.
LGTM
Comment at:
lldb/source/Plugins/InstrumentationRuntime/ASan/InstrumentationRuntimeASan.cpp:302-309
bool internal = true;
bool hardware = false;
Breakpoint *breakpoint =
process_sp->GetTarge
jingham created this revision.
jingham added reviewers: JDevlieghere, kubamracek.
Herald added a project: All.
jingham requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
lldb handles breakpoints in two phases, the "sync" and "async" phase. Th
