This revision was automatically updated to reflect the committed changes.
Closed by commit rGc418f0053600: [lldb] Fix completion of 'settings
set' values (authored by kastiglione).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134515/new/
https://re
DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the fix!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134515/new/
https://reviews.llvm.org/D134515
kastiglione added inline comments.
Comment at: lldb/test/API/functionalities/completion/TestCompletion.py:410
+"""Test that 'settins set stop-disassembly-display ' completes to [
+'never', 'always', 'no-debuginfo', 'no-source']."""
+self.complete_from_to('
kastiglione added inline comments.
Comment at: lldb/test/API/functionalities/completion/TestCompletion.py:410
+"""Test that 'settins set stop-disassembly-display ' completes to [
+'never', 'always', 'no-debuginfo', 'no-source']."""
+self.complete_from_to('
kastiglione updated this revision to Diff 462532.
kastiglione added a comment.
Rename test and change the docstring to be meaningful.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134515/new/
https://reviews.llvm.org/D134515
Files:
lldb/source/C
DavidSpickett added inline comments.
Comment at: lldb/test/API/functionalities/completion/TestCompletion.py:409
+def test_settings_set_stop_disassembly_display_value(self):
+"""Test that 'settins set stop-disassembly-display ' completes to [
+'never', 'always'
DavidSpickett added a reviewer: DavidSpickett.
DavidSpickett added inline comments.
Comment at: lldb/test/API/functionalities/completion/TestCompletion.py:409
+def test_settings_set_stop_disassembly_display_value(self):
+"""Test that 'settins set stop-disassembly-disp
kastiglione created this revision.
kastiglione added reviewers: mib, augusto2112.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Some time ago, a refactor (1153dc960) broke completion for assigning
