zequanwu marked 2 inline comments as done.
zequanwu added inline comments.
Comment at: lldb/test/Shell/SymbolFile/NativePDB/blocks.cpp:17
+
+// CHECK: Function: id = {{.*}}, name = "main", range =
[0x000140001000-0x00014000104b)
+// CHECK-NEXT: FuncType: id = {{.*}}
labath added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:372
+func->GetAddressRange().GetBaseAddress().GetFileAddress();
+Block::Range range = Block::Range(block_base - func_base, block.CodeSize);
+if (block_base >
This revision was automatically updated to reflect the committed changes.
Closed by commit rG32530e0493c1: [LLDB][NativePDB] Set block address range.
(authored by zequanwu).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133461/new/
https://reviews.l
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133461/new/
https://reviews.llvm.org/D133461
___
lldb-
zequanwu created this revision.
zequanwu added reviewers: rnk, labath.
Herald added a project: All.
zequanwu requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
The block address range was missing before.
Repository:
rG LLVM Github Monorepo
