[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. @labath thanks, I believe a more correct fix here https://reviews.llvm.org/D138348 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 ___

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

labath added a comment. The real problem here is that the `__get_fullpath__` implementation does not use the path style information from within the FileSpec object. Hardcoding it to use the host os path style (instead of posix style) just changes the set of bugs. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. I will do that and recommit, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

stella.stamenova added a comment. In D133366#3923291 , @kastiglione wrote: > Ugh, the test that is failing uses windows paths but runs on both windows and > non-windows machines. I will revert this and the two fix commits. You should be able to test fo

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. Reverted in rG01f924d0e37a5deae51df0d77e10a15b63aa0c0f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 _

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. Ugh, the test that is failing uses windows paths but runs on both windows and non-windows machines. I will revert this and the two fix commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. @stella.stamenova I realized that test has more paths that need fixing. The rest are fixed in rG760c75fe2d25e06644271cb1338f8b0f8d9abc70 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. @stella.stamenova fix is rG1ee299a57d0b5f49b6c37d81474ea030e3b122de Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. @stella.stamenova fix about to be committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

stella.stamenova added a comment. This broke the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/25854 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 ___

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG5223366416fb: [lldb] Fix SBFileSpec.fullpath for Windows (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://review

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione updated this revision to Diff 474866. kastiglione added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 Files: lldb/bindings/interface/SBFileSpec.i lldb/test/API/pyth

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 ___ lldb

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. Herald added a subscriber: JDevlieghere. will add a test before committing, there was no immediately obvious place for a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione created this revision. kastiglione added a reviewer: mib. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix `fullpath` to not assume a `/` path separator. This was discovered when D1331