This revision was automatically updated to reflect the committed changes.
Closed by commit rG4db78322031f: [LLDB] Make API tests to run using MSYS tools
(authored by omjavaid).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133002/new/
https://review
labath accepted this revision.
labath added a comment.
Seems reasonable. BTW, these days, I don't think anybody is invoking `make`
directly from the command line, so it would be fine (maybe even desirable) to
move some of this logic into python code -- particularly if it makes windows
compatibi
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
LGTM, this looks reasonable to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133002/new/
https://reviews.llvm.org/D133002
_
omjavaid created this revision.
Herald added a project: All.
omjavaid requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
MSYS 'uname' on windows returns "MSYS_NT*" instead of windows32 and also
MSYS 'pwd' returns non-windows path string.
This
