[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG48506fbbbf27: [lldb] Teach LLDB about Mach-O filesets (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://r

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

JDevlieghere updated this revision to Diff 455725. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. I added the ability to call `ObjectContainer::FindPlugin` which allows you to create a Mach-O fileset from memory without actually having to know it's a fileset. I thin

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

jasonmolenda accepted this revision. jasonmolenda added a comment. In D132433#3747948 , @jasonmolenda wrote: > `Process::ReadModuleFromMemory()` takes a FileSpec and header address in > memory (and a size to read, default 512 bytes). It calls through

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

jasonmolenda added a comment. `Process::ReadModuleFromMemory()` takes a FileSpec and header address in memory (and a size to read, default 512 bytes). It calls through `Module::GetMemoryObjectFile`. That reads the 512 bytes of memory into a buffer and calls `ObjectFile::FindPlugin` class meth

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

JDevlieghere updated this revision to Diff 455428. JDevlieghere retitled this revision from "[lldb] Teach LLDB about filesets (WIP)" to "[lldb] Teach LLDB about filesets". JDevlieghere added a comment. - Rebase - Support reading Filesets from memory CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets (WIP)

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This all looks great. I am working on a patch that will build on this, but I will be working with a memory image which needs the `CreateMemoryInstance()` ObjectFile interface impl

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets (WIP)

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a subscriber: mgorny. Herald added a project: All. JDevlieghere requested review of this revision. https://reviews.llvm.org/D132433 Files: lldb/include/lldb/Symbol/ObjectFile.h lldb/source/Plugins/Ob