This revision was automatically updated to reflect the committed changes.
Closed by commit rG65f6a8c23b53: [LLDB] Fix: make m_target_arch private
(authored by Emmmer).
Changed prior to commit:
https://reviews.llvm.org/D132353?vs=454426&id=454434#toc
Repository:
rG LLVM Github Monorepo
CHANG
DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.
I think there are a few more commented out asserts, check that a grep for
`m_target_arch` in `lldb/` doesn't turn up anything you wouldn't expect.
Otherwise LGTM. If you find any
Emmmer updated this revision to Diff 454426.
Emmmer added a comment.
Address review comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132353/new/
https://reviews.llvm.org/D132353
Files:
lldb/source/Plugins/Process/Utility/RegisterContextFreeBSD_i386.cpp
lldb/source/Plugins/Pro
DavidSpickett added inline comments.
Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoInterface.h:64
- // FIXME make private.
lldb_private::ArchSpec m_target_arch;
Rare footage of a fixme getting fixed :) Thanks!
Repository:
rG LLVM Github Mo
DavidSpickett added inline comments.
Comment at:
lldb/source/Plugins/Process/Utility/RegisterContextFreeBSD_powerpc.cpp:227
const RegisterInfo *RegisterContextFreeBSD_powerpc64::GetRegisterInfo() const {
// assert (m_target_arch.GetCore() == ArchSpec::eCore_powerpc);
+ if (
Emmmer created this revision.
Herald added subscribers: atanasyan, jrtc27, nemanjai, emaste.
Herald added a project: All.
Emmmer edited the summary of this revision.
Emmmer added reviewers: JDevlieghere, DavidSpickett.
Emmmer added a project: LLDB.
Emmmer added subscribers: imkiva, liaolucy.
Emmmer
