[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

2022-08-10 Thread David Spickett via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e538c669c76: [LLDB] Add multi value test for const static enum (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

2022-08-10 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett updated this revision to Diff 451386. DavidSpickett added a comment. invalid -> not_enumerator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131472/new/ https://reviews.llvm.org/D131472 Files: lldb/test/API/lang/cpp/const_static_i

[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

2022-08-09 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik accepted this revision. shafik added a comment. LGTM. Thank you for the quick follow-up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131472/new/ https://reviews.llvm.org/D131472 ___ lldb-commits

[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

2022-08-09 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added a comment. In D131472#3709684 , @labath wrote: > Good catch. Lldb should try to be useful even if the debugged program invokes > undefined behavior. Totally agree, for the purposes here there should be no difference for these purposes betw

[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

2022-08-09 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a reviewer: shafik. labath added a comment. Good catch. Lldb should try to be useful even if the debugged program invokes undefined behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131472/new/ htt

[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

2022-08-09 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett updated this revision to Diff 451067. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131472/new/ https://reviews.llvm.org/D131472 Files: lldb/test

[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

2022-08-09 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. 1438639a2f7eb9e9cba01454d3a9b1b16d179c9a