This revision was automatically updated to reflect the committed changes.
Closed by commit rL248597: [lldb-mi] Fix assignment operator in CMIUtilString
(authored by dperchik).
Changed prior to commit:
http://reviews.llvm.org/D13094?vs=35620&id=35741#toc
Repository:
rL LLVM
http://reviews.ll
evgeny777 updated this revision to Diff 35620.
evgeny777 added a comment.
Revised, now contains fix for just assignment operation
The "if(vpRhs != nullptr)" was removed to provide the same behaviour for
a) CMIUtilString s = (char*)nullptr;
b) s = (char*)nullptr;
http://reviews.llvm.org/D13094
brucem added a comment.
It doesn't seem right to have a strong construction and copy just to determine
the length or if it is empty or not as in your examples. That would be
appropriate for a helper function.
http://reviews.llvm.org/D13094
___
lld
brucem added a subscriber: brucem.
brucem added a comment.
http://reviews.llvm.org/D13094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
evgeny777 added inline comments.
Comment at: tools/lldb-mi/MIUtilString.cpp:41
@@ -40,3 +40,3 @@
CMIUtilString::CMIUtilString(const char *vpData)
-: std::string(vpData)
+: std::string(vpData != nullptr ? vpData : "")
{
ki.stfu wrote:
> Not sure about use
evgeny777 added a comment.
Also in MI empty value and NULL value almost always mean "no output". Checking
for NULL everywhere is just not convenient
http://reviews.llvm.org/D13094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lis
evgeny777 added a comment.
Without this change I have to use temporary const char* variable each time I
call GetData() GetSummary(), GetValue() and so on
It would be nice to be able to do something like this
CMIUtilString s = v.GetSummary();
if (!s.empty()) {
CMIUtilString v = v.GetValue();
ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
Your fix in assign operator looks good. Others go out of scope of this CL, so
please revert them.
Comment at: tools/lldb-mi/MIUtilString.cpp:41
@@ -40,3 +40,3 @@
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D13094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
