[Lldb-commits] [PATCH] D129750: [lldb] Always use APFloat for FP dumping

2022-07-27 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D129750#3681676 , @DavidSpickett wrote: > @labath Did you forget about this? Yeah, pretty much that. Committed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129750/new/ ht

[Lldb-commits] [PATCH] D129750: [lldb] Always use APFloat for FP dumping

2022-07-27 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1400a3cb8d53: [lldb] Always use APFloat for FP dumping (authored by labath). Changed prior to commit: https://reviews.llvm.org/D129750?vs=444586&id=448010#toc Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D129750: [lldb] Always use APFloat for FP dumping

2022-07-27 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. @labath Did you forget about this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129750/new/ https://reviews.llvm.org/D129750 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D129750: [lldb] Always use APFloat for FP dumping

2022-07-14 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I'm no float expert but seems fine. Also checked on AArch64 and no failures there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D129750: [lldb] Always use APFloat for FP dumping

2022-07-14 Thread Emmmer S via Phabricator via lldb-commits
Emmmer added a comment. On the riscv64 platform, LLDBCoreTests passed after applying this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129750/new/ https://reviews.llvm.org/D129750 ___ lldb-commit

[Lldb-commits] [PATCH] D129750: [lldb] Always use APFloat for FP dumping

2022-07-14 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: JDevlieghere, jingham, DavidSpickett, Emmmer. Herald added subscribers: jsji, pengfei. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. The DumpDataExtractor function had two branches for prin