This revision was automatically updated to reflect the committed changes.
Closed by commit rL247677: [lldb-mi] Clean up CMICmdArgSet usage. (authored by
brucem).
Changed prior to commit:
http://reviews.llvm.org/D12878?vs=34790&id=34797#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12878
brucem added inline comments.
Comment at: tools/lldb-mi/MICmdArgSet.cpp:92
@@ -91,3 +91,3 @@
// Type:Method.
// Args:vArg- (R) A command argument object.
// Return: None.
ki.stfu wrote:
> brucem wrote:
> > Should this say something other than `(R)`
ki.stfu accepted this revision.
ki.stfu added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: tools/lldb-mi/MICmdArgSet.cpp:92
@@ -91,3 +91,3 @@
// Type:Method.
// Args:vArg- (R) A command argument object.
// Return: None.
---
brucem added inline comments.
Comment at: tools/lldb-mi/MICmdArgSet.cpp:92
@@ -91,3 +91,3 @@
// Type:Method.
// Args:vArg- (R) A command argument object.
// Return: None.
Should this say something other than `(R)` here?
http://reviews.llvm.org/D1
brucem added a comment.
This could be cleaner still, but this is a good first pass and removes the
worst of it.
http://reviews.llvm.org/D12878
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
brucem created this revision.
brucem added reviewers: abidh, ki.stfu, domipheus.
brucem added a subscriber: lldb-commits.
CMICmdArgSet stores a vector of non-const pointers to the arguments
that it is validating. It owns them and is responsible for deleting
them.
We don't need to pass a const ref
