[Lldb-commits] [PATCH] D128543: [trace] Improve the TraceCursor iteration API

This revision was automatically updated to reflect the committed changes. Closed by commit rGf91d82816ff5: [trace] Improve the TraceCursor iteration API (authored by Walter Erquinigo ). Changed prior to commit: https://reviews.llvm.org/D128543?vs=439827&id=440810#toc Repository

[Lldb-commits] [PATCH] D128543: [trace] Improve the TraceCursor iteration API

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceCursorIntelPT.cpp:38 +void TraceCursorIntelPT::Next() { + m_pos += IsForwards() ? 1 : -1; jj10306 wrote: > should only do this increment or decrement if `HasValue()` is true? ot

[Lldb-commits] [PATCH] D128543: [trace] Improve the TraceCursor iteration API

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. lgtm, thanks for making the cursor traversal much cleaner Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:228-231 - // We insert a fake error signaling an

[Lldb-commits] [PATCH] D128543: [trace] Improve the TraceCursor iteration API

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. will take a complete look over the weekend, but wanted to point out the conflict with @persona0220's diff asap Comment at: lldb/include/lldb/Target/TraceCursor.h

[Lldb-commits] [PATCH] D128543: [trace] Improve the TraceCursor iteration API

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The current way ot traversing the cursor is a bit uncommon and it can't handl