Re: [Lldb-commits] [PATCH] D12728: New RenderScript command to break on all kernels

2015-09-10 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247262: New RenderScript command to break on all kernels (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D12728?vs=34327&id=34424#toc Repository: rL LLVM http://reviews.

Re: [Lldb-commits] [PATCH] D12728: New RenderScript command to break on all kernels

2015-09-09 Thread Jim Ingham via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks fine to me. You might want to add LIBLLDB_LOG_BREAKPOINT to your log creation, you can them together, and if I was tracking breakpoints with "log enable lldb breakpoint" I'd expe

[Lldb-commits] [PATCH] D12728: New RenderScript command to break on all kernels

2015-09-09 Thread Ewan Crawford via lldb-commits
EwanCrawford created this revision. EwanCrawford added reviewers: clayborg, jingham. EwanCrawford added subscribers: lldb-commits, domipheus, ADodds. EwanCrawford set the repository for this revision to rL LLVM. Patch adds a command to RenderScript plugin allowing users to automatically set break