Re: [Lldb-commits] [PATCH] D12674: Remove an invalid check in DW_OP_piece processing.

2015-09-09 Thread Hafiz Abid Qadeer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247124: Remove an invalid check in DW_OP_piece processing. (authored by abidh). Changed prior to commit: http://reviews.llvm.org/D12674?vs=34154&id=34301#toc Repository: rL LLVM http://reviews.llvm.

Re: [Lldb-commits] [PATCH] D12674: Remove an invalid check in DW_OP_piece processing.

2015-09-08 Thread Adrian Prantl via lldb-commits
aprantl accepted this revision. aprantl added a comment. Thanks, yes, this check looks like it serves no purpose. http://reviews.llvm.org/D12674 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [PATCH] D12674: Remove an invalid check in DW_OP_piece processing.

2015-09-07 Thread Hafiz Abid Qadeer via lldb-commits
abidh created this revision. abidh added reviewers: aprantl, clayborg. abidh added a subscriber: lldb-commits. When lldb is processing a location containing DW_OP_piece, the result is being stored in the 'pieces' variable. The location is popped from the 'stack' variable. So this check to see tha