tfiala closed this revision.
tfiala added a comment.
Great, thanks!
http://reviews.llvm.org/D12612
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Yes
On Sat, Oct 10, 2015 at 9:18 PM Todd Fiala wrote:
> tfiala added a comment.
>
> Did this go in, Zachary? I'm just looking to clear out my reviews and
> this one seems to still be open.
>
>
> http://reviews.llvm.org/D12612
>
>
>
>
___
lldb-commits
tfiala added a comment.
Did this go in, Zachary? I'm just looking to clear out my reviews and this one
seems to still be open.
http://reviews.llvm.org/D12612
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
I tried that at first, but unfortunately in order to do that you have to
write a line like
global dont_do_dsym_test
for every global accessed by main. Like you said, Todd can probably clean
that up, for now I just wanted to get something working.
On Thu, Sep 3, 2015 at 4:02 PM Ying Chen wrote:
tfiala added a comment.
In http://reviews.llvm.org/D12612#239698, @chying wrote:
> This patch works for me.
> Although I thought we could put less code in main() function.
> Then have
> if __name__ == "__main__":
>
> main()
>
> But that will require some more work to refactor the code. Prob
chying accepted this revision.
chying added a comment.
This patch works for me.
Although I thought we could put less code in main() function.
Then have
if __name__ == "__main__":
main()
But that will require some more work to refactor the code. Probably that could
wait for Todd's clean up.
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Okay I see, makes sense. Particularly the discrepancy.
That code will get much nicer (in dotest.py) when that gets some energy put
into cleaning it up.
Thanks for tracking it down, Zachary!
zturner created this revision.
zturner added reviewers: tfiala, amccarth, chying.
zturner added a subscriber: lldb-commits.
On Windows, when you call pool.map, under the hood python will *again* import
whatever the main module is. In this case it's dotest.py. Importing dotest
then causes all o
