Re: [Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

2015-09-04 Thread Pavel Labath via lldb-commits
labath added a comment. In http://reviews.llvm.org/D12599#239378, @tfiala wrote: > 13% size decrease sounds nice! Was that with a DebugAsserts build, > optimized, or what? This was a release build (-O3 -DNDEBUG). Size went down from ~58 to ~51 MB. > tfiala, on Mac OS X with this change, the

Re: [Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

2015-09-03 Thread Bruce Mitchener via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246822: Only export public symbols with the cmake build. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D12599?vs=33942&id=33993#toc Repository: rL LLVM http://reviews.llvm.o

Re: [Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

2015-09-03 Thread Bruce Mitchener via lldb-commits
brucem added a comment. tfiala, on Mac OS X with this change, the liblldb.dylib went from 58468408 to 53626572 bytes (release build). http://reviews.llvm.org/D12599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

2015-09-03 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine. http://reviews.llvm.org/D12599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

2015-09-03 Thread Todd Fiala via lldb-commits
tfiala added a subscriber: tfiala. tfiala added a comment. In http://reviews.llvm.org/D12599#239281, @labath wrote: > The linux parts are ok. This reduces the size of liblldb by about 13%. Good > work. :) 13% size decrease sounds nice! Was that with a DebugAsserts build, optimized, or what?

Re: [Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

2015-09-03 Thread Pavel Labath via lldb-commits
labath added a comment. The linux parts are ok. This reduces the size of liblldb by about 13%. Good work. :) http://reviews.llvm.org/D12599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

Re: [Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

2015-09-03 Thread Bruce Mitchener via lldb-commits
brucem added a comment. This uses some machinery from LLVM's cmake scripts. I'm not sure what happens with this on FreeBSD, NetBSD, etc. http://reviews.llvm.org/D12599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/

[Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

2015-09-03 Thread Bruce Mitchener via lldb-commits
brucem created this revision. brucem added reviewers: emaste, clayborg, labath, chaoren. brucem added a subscriber: lldb-commits. This also moves the xcode support files to be near or the same as the ones used for cmake. The source/API/liblldb.xcodes.exports differs from the source/API/liblldb.ex