Re: [Lldb-commits] [PATCH] D12527: Address flakyness in TestAttachResume

2015-09-02 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246623: Address flakyness in TestAttachResume (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12527?vs=33689&id=33785#toc Repository: rL LLVM http://reviews.llvm.org/D12527

Re: [Lldb-commits] [PATCH] D12527: Address flakyness in TestAttachResume

2015-09-01 Thread Pavel Labath via lldb-commits
labath updated this revision to Diff 33689. labath added a comment. I've found another source or racyness in the test. The test verified that the process resumes and stops after a "continue". However, if these two events happened two fast, the initial start event would be lost, and the test woul

[Lldb-commits] [PATCH] D12527: Address flakyness in TestAttachResume

2015-09-01 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: zturner, clayborg. labath added a subscriber: lldb-commits. The test (among other things) attempts to verify that detaching works while the inferior is running. However, this was racy since the inferior could end up stopping again before we g