This revision was automatically updated to reflect the committed changes.
Closed by commit rG760298adc264: [lldb] Specify aguments of `image list`
(authored by kastiglione).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125154/new/
https://reviews.l
JDevlieghere added a comment.
LGTM
PS: Small typo in your summary: `s/abot/about/`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125154/new/
https://reviews.llvm.org/D125154
___
lldb-commits mailing li
kastiglione added a comment.
@DavidSpickett I might do some follow up work, if so I will add coverage then.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125154/new/
https://reviews.llvm.org/D125154
___
kastiglione updated this revision to Diff 428481.
kastiglione added a comment.
add to TestHelp.py
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125154/new/
https://reviews.llvm.org/D125154
Files:
lldb/source/Commands/CommandObjectTarget.cpp
ll
DavidSpickett added a comment.
Can you add a test for the help output to
`lldb/test/API/commands/help/TestHelp.py` ? Just the one line that includes the
argument list is fine.
Also I see that we don't test this part of the command at all. Not an issue for
this change (I assume it is working fo
kastiglione created this revision.
kastiglione added reviewers: aprantl, jingham.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Register positional argument details in `CommandObjectTargetModulesLi
