Re: [Lldb-commits] [PATCH] D12507: Implement DoReadMemory for Windows mini dumps

2015-09-01 Thread Adrian McCarthy via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246558: Implement DoReadMemory for Windows mini dumps. (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D12507?vs=33644&id=33708#toc Repository: rL LLVM http://reviews.llvm.o

Re: [Lldb-commits] [PATCH] D12507: Implement DoReadMemory for Windows mini dumps

2015-09-01 Thread Zachary Turner via lldb-commits
zturner accepted this revision. This revision is now accepted and ready to land. Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:249-252 @@ -240,3 +248,6 @@ { -// TODO -return 0; +// I don't have a sense of how frequently this is called or

[Lldb-commits] [PATCH] D12507: Implement DoReadMemory for Windows mini dumps

2015-08-31 Thread Adrian McCarthy via lldb-commits
amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. Implements DoReadMemory for Windows mini dumps. The dumps can use two slightly different methods for capturing ranges of memory, so I abstracted away the search for a range from the ac