[Lldb-commits] [PATCH] D123357: [trace][intelpt] Add task timer classes

wallace closed this revision. wallace added a comment. Committed as bdf3e7e5b886ab690a82e8d34b4502d9c6c5d6a9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123357/new/ https://re

[Lldb-commits] [PATCH] D123357: [trace][intelpt] Add task timer classes

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:243 + /// Total amount of time spent decoding. + std::chrono::milliseconds m_total_decoding_time{0}; }; jj10306 wrote: > nit: Do you need an explicit initialization?

[Lldb-commits] [PATCH] D123357: [trace][intelpt] Add task timer classes

jj10306 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:243 + /// Total amount of time spent decoding. + std::chrono::milliseconds m_total_decoding_time{0}; }; nit: Do you need an explicit initialization? ===

[Lldb-commits] [PATCH] D123357: [trace][intelpt] Add task timer classes

wallace created this revision. Herald added a subscriber: mgorny. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I'm adding two new classes that can be used to measure the duration of long tasks as proc