[Lldb-commits] [PATCH] D122988: [BOLT][DWARF] Add version 5 split dwarf support

maksfb accepted this revision. maksfb added a comment. This revision is now accepted and ready to land. Awesome! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122988/new/ https://reviews.llvm.org/D122988 ___

[Lldb-commits] [PATCH] D122988: [BOLT][DWARF] Add version 5 split dwarf support

ayermolo added inline comments. Comment at: bolt/include/bolt/Core/DebugData.h:375-377 +if (Optional DWOId = Unit.getDWOId()) + return *DWOId; +return Unit.getOffset(); dblaikie wrote: > ayermolo wrote: > > ayermolo wrote: > > > dblaikie wrote: > > >

[Lldb-commits] [PATCH] D122988: [BOLT][DWARF] Add version 5 split dwarf support

ayermolo added inline comments. Comment at: bolt/include/bolt/Core/DebugData.h:375-377 +if (Optional DWOId = Unit.getDWOId()) + return *DWOId; +return Unit.getOffset(); ayermolo wrote: > dblaikie wrote: > > That seems like a somewhat problematic API

[Lldb-commits] [PATCH] D122988: [BOLT][DWARF] Add version 5 split dwarf support

ayermolo added inline comments. Comment at: bolt/include/bolt/Core/DebugData.h:375-377 +if (Optional DWOId = Unit.getDWOId()) + return *DWOId; +return Unit.getOffset(); dblaikie wrote: > That seems like a somewhat problematic API - returning two very

[Lldb-commits] [PATCH] D122988: [BOLT][DWARF] Add version 5 split dwarf support

dblaikie added inline comments. Comment at: bolt/include/bolt/Core/DebugData.h:375-377 +if (Optional DWOId = Unit.getDWOId()) + return *DWOId; +return Unit.getOffset(); ayermolo wrote: > ayermolo wrote: > > dblaikie wrote: > > > That seems like a som

[Lldb-commits] [PATCH] D122988: [BOLT][DWARF] Add version 5 split dwarf support

ayermolo updated this revision to Diff 425001. ayermolo added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122988/new/ https://reviews.llvm.org/D