Re: [Lldb-commits] [PATCH] D12280: Make TestCreateDuringInstructionStep linux-specific

2015-08-24 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL245838: Make TestCreateDuringInstructionStep linux-specific (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12280?vs=32950&id=32952#toc Repository: rL LLVM http://reviews.llv

Re: [Lldb-commits] [PATCH] D12280: Make TestCreateDuringInstructionStep linux-specific

2015-08-24 Thread Pavel Labath via lldb-commits
labath added a comment. There is a similar issue during thread destruction, although the underlying reason is a bit different. I have created bug #24551 to track that. http://reviews.llvm.org/D12280 ___ lldb-commits mailing list lldb-commits@lists.

Re: [Lldb-commits] [PATCH] D12280: Make TestCreateDuringInstructionStep linux-specific

2015-08-24 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good with 2 minor comments - After the renames the test path don't say that the test is thread related. I think you should add it back to somewhere (e.g. to the test name) - Sh

[Lldb-commits] [PATCH] D12280: Make TestCreateDuringInstructionStep linux-specific

2015-08-24 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: tberghammer. labath added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. There were a number of issues about the way I have designed this test originally: - it relied on single-stepping through large pa