[Lldb-commits] [PATCH] D121912: [lldb] Fix ^C handling in IOHandlerProcessSTDIO

2022-03-18 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D121912#3389378 , @DavidSpickett wrote: > Do you know if the pexpect test will cleanup the debugee process if some part > of the test fails? Or will we have that hanging around in its infinite loop? It won't, but the debuggee

[Lldb-commits] [PATCH] D121912: [lldb] Fix ^C handling in IOHandlerProcessSTDIO

2022-03-17 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf93d861349f9: [lldb] Fix ^C handling in IOHandlerProcessSTDIO (authored by labath, committed by JDevlieghere). Changed prior to commit: https://re

[Lldb-commits] [PATCH] D121912: [lldb] Fix ^C handling in IOHandlerProcessSTDIO

2022-03-17 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121912/new/ https://reviews.llvm.org/D121912

[Lldb-commits] [PATCH] D121912: [lldb] Fix ^C handling in IOHandlerProcessSTDIO

2022-03-17 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. I also found this in the process of looking at https://github.com/llvm/llvm-project/issues/53673 (different issue same area). Bisected it to the same change you got, and this fixes things for me too. Do you know if the pexpect test will cleanup the debugee process

[Lldb-commits] [PATCH] D121912: [lldb] Fix ^C handling in IOHandlerProcessSTDIO

2022-03-17 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added a reviewer: JDevlieghere. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. D120762 accidentally moved the interrupt check into the block which was reading stdio. This