This revision was automatically updated to reflect the committed changes.
Closed by commit rGb6087ba769c6: Disable LLDB index cache for .o files with no
UUID. (authored by clayborg).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120948/new/
https://
clayborg updated this revision to Diff 416334.
clayborg added a comment.
Address operator == inline suggestion for CacheSignature
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120948/new/
https://reviews.llvm.org/D120948
Files:
lldb/include/lldb
yinghuitan added inline comments.
Comment at: lldb/include/lldb/Core/DataFileCache.h:130-138
+ bool operator==(const CacheSignature &rhs) const {
if (m_uuid != rhs.m_uuid)
- return true;
+ return false;
if (m_mod_time != rhs.m_mod_time)
- return true;
+
clayborg updated this revision to Diff 413115.
clayborg added a comment.
Added unit tests for CacheSignature that covers:
- making sure encoding fails when we have an invalid CacheSignature
- make sure decoding of older cache files that had a previously valid signature
fails when there is no UUI
yinghuitan added inline comments.
Comment at: lldb/include/lldb/Core/DataFileCache.h:127
+ /// unique idenifier like the UUID being valid.
+ bool IsValid() const { return m_uuid.hasValue(); }
yinghuitan wrote:
> Do we plan to ship with this design (no caching
yinghuitan accepted this revision.
yinghuitan added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/include/lldb/Core/DataFileCache.h:127
+ /// unique idenifier like the UUID being valid.
+ bool IsValid() const { return m_uuid.hasValue(); }
clayborg created this revision.
clayborg added reviewers: labath, JDevlieghere, jingham, aadsm, wallace,
yinghuitan.
Herald added a subscriber: arphaman.
Herald added a project: All.
clayborg requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
