[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f438185a68a: Fix up the "lldb log break" channel output. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120917/new/ https://reviews.l

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

jingham added inline comments. Comment at: lldb/include/lldb/Breakpoint/Breakpoint.h:84 static ConstString GetEventIdentifier(); + static const char * + BreakpointEventTypeAsCString(lldb::BreakpointEventType type); JDevlieghere wrote: > Why not a llvm::S

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Breakpoint/Breakpoint.h:84 static ConstString GetEventIdentifier(); + static const char * + BreakpointEventTypeAsCString(lldb::BreakpointEventType type); Why not a llvm::StringRef? Repos

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

kastiglione accepted this revision. kastiglione added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Utility/Broadcaster.cpp:211-215 + Log *log = GetLog(LLDBLog::Events); + if (!log && event_sp->GetData()) +log = event_sp->GetData(

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

jingham added inline comments. Comment at: lldb/source/Breakpoint/Breakpoint.cpp:1063-1065 + break_id_t bkpt_id = GetBreakpoint()->GetID(); + s->Format("bkpt: {0} type: {1}", bkpt_id, + BreakpointEventTypeAsCString(event_type)); kastiglione wrote: > For th

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

kastiglione added inline comments. Comment at: lldb/source/Breakpoint/Breakpoint.cpp:1063-1065 + break_id_t bkpt_id = GetBreakpoint()->GetID(); + s->Format("bkpt: {0} type: {1}", bkpt_id, + BreakpointEventTypeAsCString(event_type)); For the location event

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

kastiglione added inline comments. Comment at: lldb/source/Utility/Broadcaster.cpp:211-215 + Log *log = GetLog(LLDBLog::Events); + if (!log && event_sp->GetData()) +log = event_sp->GetData()->GetLogChannel(); + + if (log) { should this log to both channels

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

jingham added a comment. For instance, one of the other EventData types might want the events too, but only when the verbose flag for their relevant log channel is on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120917/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

jingham created this revision. jingham added reviewers: labath, JDevlieghere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I was trying to figure out a problem with how a client was seeing the breakp