thakis added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120321/new/
https://reviews.llvm.org/D120321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
thakis added a comment.
Looks like this breaks building on Windows:
http://45.33.8.238/win/53761/step_4.txt
Please take a look.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120321/new/
https://reviews.llvm.org/D120321
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd0810779b1f3: [lldb] Modernize ThreadLauncher (authored by
labath).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120321/new/
https://reviews.llvm.org/D1203
labath added inline comments.
Comment at: lldb/source/Host/common/HostNativeThreadBase.cpp:55-56
HostNativeThreadBase::ThreadCreateTrampoline(lldb::thread_arg_t arg) {
- ThreadLauncher::HostThreadCreateInfo *info =
- (ThreadLauncher::HostThreadCreateInfo *)arg;
- llvm::se
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Nice cleanup
Comment at: lldb/source/Host/common/HostNativeThreadBase.cpp:55-56
HostNativeThreadBase::ThreadCreateTrampoline(lldb::thread_arg_t arg) {
- ThreadL
labath created this revision.
labath added a reviewer: JDevlieghere.
Herald added a subscriber: mgorny.
labath requested review of this revision.
Herald added a project: LLDB.
Accept a function object instead of a raw pointer. This avoids a bunch
of boilerplate typically needed to pass arguments t
