JDevlieghere added a comment.
Assuming all issues have been fixed, can you add this clang-tidy check to the
`.clang-tidy` file in the root of the repository? That should make it less
likely this regresses again in the future.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
h
aprantl added a comment.
Herald added a subscriber: JDevlieghere.
Nice.
Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:261
if (m_pair_ptr) {
- auto __i_(valobj_sp->GetChildMemberWithName(g___i_, true));
+ auto __i_(valobj_sp->GetChildMemberWithName
This revision was automatically updated to reflect the committed changes.
Closed by commit rG80a11e080358: [LLDB] Replace use of double underscore in
identifiers (authored by shafik).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.
shafik updated this revision to Diff 409344.
shafik added a comment.
Used shorter options for renaming based on feedback.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119915/new/
https://reviews.llvm.org/D119915
Files:
lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp
lldb/source/
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Yeah, we shouldn't be using these. Personally, I think the names are now
unnecessarily long, and I'd go with something shorter. E.g. replacing the
double underscore (btw, in python land they a
shafik created this revision.
shafik added reviewers: labath, aprantl.
shafik requested review of this revision.
Identifiers with `__` anywhere are reserved. I picked this up via the
`bugprone-reserved-identifier` clang-tidy check but `-Wreserved-identifier`
will also flag these uses as well.
