[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

2022-01-20 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova abandoned this revision. stella.stamenova added a comment. I spent a bit of time trying to investigate the failures, but I couldn't make much progress and I don't have time to dedicate to a more thorough investigation. It looks like there are a few tests that outright fail (inc

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

2022-01-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. TBH, I am not really surprised by that. My recollection was that windows lldb-server was still missing some features to be a viable replacement, but I was hoping that I have recalled incorrectly. It'd definitely be interesting to see what the missing pieces are. Reposi

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

2022-01-18 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added a comment. So, sadly, I am going to have to backtrack here. When I set `LLDB_USE_LLDB_SERVER` in my environment and ran the tests, they did appear to be more stable (fewer failures across 10 test runs), but it was all a joke my machine was playing on me. Running the test

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

2022-01-18 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. ship it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117581/new/ https://reviews.llvm.org/D117581

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

2022-01-18 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova created this revision. stella.stamenova added reviewers: JDevlieghere, clayborg, labath. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The current default is to not use lldb-server on Windows, however, ll