sylvestre.ledru added a comment.
Seems that it broke apt.llvm.org on ubuntu bionic with Python 3.6:
I reported this issue: https://github.com/llvm/llvm-project/issues/53291
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114722/new/
https://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa6598575f4bc: [LLDB] Fix Python GIL-not-held issues
(authored by rwgk, committed by labath).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114722/new/
https
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:277-285
+ if (_Py_IsFinalizing()) {
+// Leak m_py_obj rather than
labath updated this revision to Diff 399302.
labath added a comment.
This just fixes the style issues.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114722/new/
https://reviews.llvm.org/D114722
Files:
lldb/source/Plugins/ScriptInterpreter/Python
labath commandeered this revision.
labath edited reviewers, added: rupprecht; removed: labath.
labath added a reviewer: mib.
labath added inline comments.
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:277-285
+ if (_Py_IsFinalizing()) {
+
rupprecht updated this revision to Diff 398652.
rupprecht added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114722/new/
https://reviews.llvm.org/D114722
Files:
lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cp
labath added a reviewer: JDevlieghere.
labath added inline comments.
Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:101
+ } else {
+auto gstate = PyGILState_Ensure();
+Py_XDECREF(GetValue());
This usage of auto i
rupprecht created this revision.
rupprecht added a reviewer: labath.
rupprecht requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
The GIL must be held when calling any Python C API functions. In multithreaded
applications that use callbacks t
