[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

This revision was automatically updated to reflect the committed changes. Closed by commit rG1408684957bb: [lldb] Introduce PlatformQemuUser (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114509/new/ https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

labath added a comment. Thanks for the review. I'm going to wait until the US folks get back before submitting this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114509/new/ https://reviews.llvm.org/D114509 __

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

DavidSpickett accepted this revision. DavidSpickett added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114509/new/ https://reviews.llvm.org/D114509 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

labath added a comment. In D114509#3151035 , @mgorny wrote: > That said, I wonder if we should use some formatter (e.g. `black`) for Python > files. While I can't really say I like black's coding style, it's quite > popular and using some formatter woul

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

labath updated this revision to Diff 389717. labath marked an inline comment as done. labath added a comment. feedback David Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114509/new/ https://reviews.llvm.org/D114509 Files: lldb/packages/Python/l

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

labath marked 4 inline comments as done. labath added a comment. In D114509#3151461 , @DavidSpickett wrote: >> qemu also does not support macOS > > Do you mean qemu-user here? Yes, definitely. In D114509#3151581

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

DavidSpickett added a comment. > some things in this patch are called "Qemu" (the plugin folder, for instance) I wouldn't pay much attention to the `qemu-system` idea, it was just a hypothetical from me. Unless it's something that you would call a public API. Like the platform's name for exampl

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

DavidSpickett added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/gdbclientutils.py:505 except: +traceback.print_exc() return Is this something that happens every so often during testing and can be mostly igno

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

DavidSpickett added a comment. > qemu also does not support macOS Do you mean qemu-user here? I agree being able to run the tests there is nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114509/new/ https://reviews.llvm.org/D114509 _

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. That said, I wonder if we should use some formatter (e.g. `black`) for Python files. While I can't really say I like black's coding style, it's quite popular and using some formatter would be

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

labath updated this revision to Diff 389443. labath marked 4 inline comments as done. labath added a comment. Address Michał's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114509/new/ https://reviews.llvm.org/D114509 Files: lldb/packa

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

labath marked 4 inline comments as done. labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/gdbclientutils.py:403 return self._connection.sendall(data) +class TCPServerSocket(ServerSocket): mgorny wrote: > It's customary (rea

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

mgorny added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/gdbclientutils.py:403 return self._connection.sendall(data) +class TCPServerSocket(ServerSocket): It's customary (read: PEP8) to use two empty lines between global-scope stuf

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

labath created this revision. labath added reviewers: JDevlieghere, DavidSpickett, mgorny. labath requested review of this revision. Herald added a project: LLDB. This adds a new platform class, whose job is to enable running (debugging) executables under qemu. (For general information about qemu