[Lldb-commits] [PATCH] D114458: Make some libstd++ formatters safer

This revision was automatically updated to reflect the committed changes. Closed by commit rGa48501150b9e: Make some libstd++ formatters safer (authored by Walter Erquinigo ). Changed prior to commit: https://reviews.llvm.org/D114458?vs=389267&id=389315#toc Repository: rG LLV

[Lldb-commits] [PATCH] D114458: Make some libstd++ formatters safer

wallace updated this revision to Diff 389267. wallace added a comment. labath's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114458/new/ https://reviews.llvm.org/D114458 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb/source/Plug

[Lldb-commits] [PATCH] D114458: Make some libstd++ formatters safer

wallace added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unordered/main.cpp:16 -int main() { +int main() { // Set break point at this line. std::unordered_map map; labath wrote: > It'd be better to

[Lldb-commits] [PATCH] D114458: Make some libstd++ formatters safer

labath added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unordered/main.cpp:16 -int main() { +int main() { // Set break point at this line. std::unordered_map map; It'd be better to be more explicit

[Lldb-commits] [PATCH] D114458: Make some libstd++ formatters safer

wallace created this revision. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We need to add checks that ensure that some core variables are valid, so that we avoid printing out garbage data. The worst that could happen is that an