[Lldb-commits] [PATCH] D114450: Improve optional formatter

labath added a comment. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114450/new/ https://reviews.llvm.org/D114450 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D114450: Improve optional formatter

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ba5da8e3d38: Improve optional formatter (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114450/new/ https://

[Lldb-commits] [PATCH] D114450: Improve optional formatter

wallace updated this revision to Diff 389260. wallace added a comment. fix the issue when both formatters run together and apply labath's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114450/new/ https://reviews.llvm.org/D114450 Files:

[Lldb-commits] [PATCH] D114450: Improve optional formatter

labath added a comment. In D114450#3149281 , @wallace wrote: >> That said, I'm more worried about the strange interactions between libc++ >> and libstdc++ formatters I reported. > > yes, I'm trying to install libc++ on my machine now Cool, thanks. ==

[Lldb-commits] [PATCH] D114450: Improve optional formatter

wallace added a comment. > That said, I'm more worried about the strange interactions between libc++ and > libstdc++ formatters I reported. yes, I'm trying to install libc++ on my machine now Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:24 self.value = se

[Lldb-commits] [PATCH] D114450: Improve optional formatter

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I didn't realize that _M_engaged has type bool. That means the max value this could have is 255, which isn't nearly as bad as 0x. Nonetheless, this is a good change. That said, I'm mo

[Lldb-commits] [PATCH] D114450: Improve optional formatter

wallace created this revision. wallace added a reviewer: labath. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As suggested by @labath in https://reviews.llvm.org/D114403, we should make the formatter more resilient to corrupted d