[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

2021-11-15 Thread Zequan Wu via Phabricator via lldb-commits
zequanwu added a comment. In D113821#3133324 , @stella.stamenova wrote: > I think this broke the windows bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/12036 Thanks, hopefully this will fix it: rGb6d35352304601925bc1c055106949d2e27b3975

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

2021-11-15 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added a comment. I think this broke the windows bot: https://lab.llvm.org/buildbot/#/builders/83/builds/12036 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113821/new/ https://reviews.llvm.org/D113821

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

2021-11-15 Thread Zequan Wu via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf17404a733c1: [LLDB][NativePDB] Fix image lookup by address (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D113821?vs=387348&id=387355#toc Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

2021-11-15 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/Shell/SymbolFile/NativePDB/lookup-by-address.cpp:12 +// ADDRESS: image lookup -a 0x401000 +// ADDRESS: Address: lookup-by-address.cpp.tmp.exe[0x{{[0

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

2021-11-15 Thread Zequan Wu via Phabricator via lldb-commits
zequanwu updated this revision to Diff 387348. zequanwu marked an inline comment as done. zequanwu added a comment. Use `/base:0x40` in test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113821/new/ https://reviews.llvm.org/D113821 Files

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

2021-11-14 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/lookup-by-address.cpp:8 +// RUN: FileCheck --input-file=%t.out %s --check-prefix=NAME +// RUN: address=`grep "Address:" %t.out | sed "s/.*Address: lookup-by-address.cpp.tmp.exe\[\(.*\)\].*/\1/"` +// R

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

2021-11-12 Thread Zequan Wu via Phabricator via lldb-commits
zequanwu created this revision. zequanwu added a reviewer: labath. zequanwu requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. `image lookup -a ` doesn't work because the compilands list is always e