[Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

2021-11-09 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113400/new/ https://reviews.llvm.org/D113400 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

2021-11-09 Thread Andy Yankovsky via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdc8f0035ca99: [lldb-vscode] Add presentation hints for scopes (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113400/new/ https://reviews

[Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

2021-11-09 Thread Andy Yankovsky via Phabricator via lldb-commits
werat added a comment. Thanks! I have push permission, will land it myself in a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113400/new/ https://reviews.llvm.org/D113400 ___ lldb-commits mailing lis

Re: [Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

2021-11-09 Thread Walter via lldb-commits
Cool. I hope that vscode catches up. Do you have push permissions or should I land this for you? Il Mar 9 Nov 2021, 2:16 AM Andy Yankovsky via Phabricator < revi...@reviews.llvm.org> ha scritto: > werat added a comment. > > In D113400#3117500 , @wallace

[Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

2021-11-09 Thread Andy Yankovsky via Phabricator via lldb-commits
werat added a comment. In D113400#3117500 , @wallace wrote: > could you share a screenshot of how this looks like? Sure! Here are the screenshots of before/after in Visual Studio 2022. Before everything is in one place (in Locals Window): F20179455: vis

[Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

2021-11-08 Thread walter erquinigo via Phabricator via lldb-commits
wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. could you share a screenshot of how this looks like? And thanks for doing this!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113400/new/ ht

[Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

2021-11-08 Thread Andy Yankovsky via Phabricator via lldb-commits
werat created this revision. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Scopes can have an optional hint for how to present this scope in the UI: https://microsoft.github.io/debug-adapter-protocol/specification#Types_Scope The I