[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

lawrence_danna added a comment. In D112988#3103992 , @stella.stamenova wrote: > It looks like some of the tests need to be updated after this change (at > least on Windows, the Windows LLDB bot is broken now): > > https://lab.llvm.org/buildbot/#/builder

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

stella.stamenova added a comment. It looks like some of the tests need to be updated after this change (at least on Windows, the Windows LLDB bot is broken now): https://lab.llvm.org/buildbot/#/builders/83/builds/11623/steps/7/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

JDevlieghere added inline comments. Comment at: lldb/test/Shell/Driver/TestQuiet.test:8 +CHECK: 42 \ No newline at end of file > No newline at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112988/new/

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2a6c08bbc38: [lldb] fix --source-quietly (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112988/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

lawrence_danna added a comment. In D112988#3103574 , @jingham wrote: > Ha! It was apparently so easy to add the test that it wasn't noticeable (at > least by me!). > > This isn't directly relevant to your patch, since this wasn't behavior you > changed

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Ha! It was apparently so easy to add the test that it wasn't noticeable (at least by me!). This isn't directly relevant to your patch, since this wasn't behavior you changed, but it seems

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

lawrence_danna marked an inline comment as done. lawrence_danna added a comment. In D112988#3103463 , @jingham wrote: > There was one typo I pointed out, and it would be good to add a test. I'm > sure this worked at some point, but wasn't tested so it w

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

lawrence_danna updated this revision to Diff 384155. lawrence_danna added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112988/new/ https://reviews.llvm.org/D112988 Files: lldb/docs/man/lldb.rst lldb/test/Shell/Driver/TestQ

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

jingham added a comment. This is great, thanks! There was one typo I pointed out, and it would be good to add a test. I'm sure this worked at some point, but wasn't tested so it was broken without anybody noticing. We want to make sure that doesn't happen again... It should be easy to write

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham. Herald added subscribers: dang, pengfei. lawrence_danna requested review of this revision. Herald added a project: LLDB. Jim says: lldb has a -Q or --source-quietly option, which supposedly