[Lldb-commits] [PATCH] D112706: [lldb/test] Allow indentation in inline tests

shafik added a comment. I agree, we should be trying to get ride of inline tests. The last time I had to debug one it was not a fun experience. Maybe some of the recent improvements have helped there though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D112706: [lldb/test] Allow indentation in inline tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG349295fcf37e: [lldb/test] Allow indentation in inline tests (authored by labath). Changed prior to commit: https://reviews.llvm.org/D112706?vs=382991&id=383000#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D112706: [lldb/test] Allow indentation in inline tests

labath marked an inline comment as done. labath added a comment. In D112706#3093179 , @teemperor wrote: > On a more general note: I wish we would just kill off inline tests instead of > trying to make them usable. But I think that's a discussion for the

[Lldb-commits] [PATCH] D112706: [lldb/test] Allow indentation in inline tests

labath marked 2 inline comments as done. labath added inline comments. Comment at: lldb/test/API/test_utils/TestInlineTest.py:10 + +def test(self): +filename = self.getBuildArtifact("test_file.cpp") teemperor wrote: > teemperor wrote: > > nit: maybe g

[Lldb-commits] [PATCH] D112706: [lldb/test] Allow indentation in inline tests

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks. On a more general note: I wish we would just kill off inline tests instead of trying to make them usable. But I think that's a discussion for the mailing lists... =

[Lldb-commits] [PATCH] D112706: [lldb/test] Allow indentation in inline tests

labath created this revision. labath added reviewers: teemperor, mgorny. labath requested review of this revision. Herald added a project: LLDB. This makes it possible to use for loops (and other language constructs) in inline tests. Repository: rG LLVM Github Monorepo https://reviews.llvm.or