[Lldb-commits] [PATCH] D110997: [lldb] Restore tty attributes on disconnect

mgorny abandoned this revision. mgorny added a comment. If at all, this will be part of the new serial port API. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110997/new/ https://reviews.llvm.org/D110997 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D110997: [lldb] Restore tty attributes on disconnect

mgorny added a comment. In D110997#3041802 , @labath wrote: > That does not sound unreasonable, though I'm not sure how much is it actually > useful. Do you know if its like standard practice when working with serial > ports, ttys and stuff? To be hone

[Lldb-commits] [PATCH] D110997: [lldb] Restore tty attributes on disconnect

labath added a comment. In D110997#3039575 , @mgorny wrote: > In D110997#3039540 , @labath wrote: > >> Why is it important to restore the tty settings? (just asking, I have no >> clue about how this is supposed t

[Lldb-commits] [PATCH] D110997: [lldb] Restore tty attributes on disconnect

mgorny added a comment. In D110997#3039540 , @labath wrote: > Why is it important to restore the tty settings? (just asking, I have no clue > about how this is supposed to work) Well, maybe my logic is wrong but the idea is that since LLDB overrides ser

[Lldb-commits] [PATCH] D110997: [lldb] Restore tty attributes on disconnect

labath added a comment. Why is it important to restore the tty settings? (just asking, I have no clue about how this is supposed to work) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110997/new/ https://reviews.llvm.org/D110997 ___ lldb-com

[Lldb-commits] [PATCH] D110997: [lldb] Restore tty attributes on disconnect

mgorny updated this revision to Diff 376717. mgorny added a comment. Make use of `Terminal` class as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110997/new/ https://reviews.llvm.org/D110997 Files: lldb/include/lldb/Host/posix/ConnectionFileDescriptorPosix.h lldb/source/Host

[Lldb-commits] [PATCH] D110997: [lldb] Restore tty attributes on disconnect

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. mgorny requested review of this revision. When connecting to a teletype, LLDB sets baud rate and switches it to raw mode. Restore the original attributes on disconnect. https://reviews.llvm.org/D110997