[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState

This revision was automatically updated to reflect the committed changes. Closed by commit rG58b4501eeabb: [lldb] [Host] Refactor TerminalState (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D110721?vs=376271&id=376468#toc Repository: rG

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState

mgorny marked 2 inline comments as done. mgorny added a comment. In D110721#3035879 , @labath wrote: > Is anyone passing save_process_group = true now? If not, I'd really like to > delete it, as the implementation is quite scary. Yes, `Debugger::SaveInp

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Is anyone passing save_process_group = true now? If not, I'd really like to delete it, as the implementation is quite scary. Comment at: lldb/include/lldb/Host/Terminal.h:51

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState

mgorny updated this revision to Diff 376271. mgorny added a comment. Move saving/restoring termios back into `TerminalState`, make `Impl` a trivial struct. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110721/new/ https://reviews.llvm.org/D110721 Files: lldb/include/lldb/Host/Termin

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState

mgorny updated this revision to Diff 376191. mgorny edited the summary of this revision. mgorny added a comment. Move termios data to PImpl-style subclass. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110721/new/ https://reviews.llvm.org/D110721 Files: lldb/include/lldb/Host/Termina

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/include/lldb/Host/Terminal.h:51 /// descriptor and later restore that state as it originally was. class TerminalState { public: labath wrote: > I guess it would be good to

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState

labath added a comment. Overall, this seems like an improvement, though the class is still quite far from what I would consider an ideal state. Comment at: lldb/include/lldb/Host/Terminal.h:51 /// descriptor and later restore that state as it originally was. class TerminalSt

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/include/lldb/Host/Terminal.h:20 + struct termios; shafik wrote: > I don't think we need this forward declaration anymore. You are correct, thanks! CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState

mgorny updated this revision to Diff 375945. mgorny added a comment. Fix `tcgetpgrp()` call (again). Remove unneeded forward decl. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110721/new/ https://reviews.llvm.org/D110721 Files: lldb/include/lldb/Host/Terminal.h lldb/source/Host/co

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState

shafik added inline comments. Comment at: lldb/include/lldb/Host/Terminal.h:20 + struct termios; I don't think we need this forward declaration anymore. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110721/new/ https://reviews.llvm.org/D110721

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState [WIP]

mgorny updated this revision to Diff 375928. mgorny added a comment. Accept `Terminal` arg in place of fd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110721/new/ https://reviews.llvm.org/D110721 Files: lldb/include/lldb/Host/Terminal.h lldb/source/Host/common/Terminal.cpp lldb

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState [WIP]

mgorny updated this revision to Diff 375919. mgorny edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110721/new/ https://reviews.llvm.org/D110721 Files: lldb/include/lldb/Host/Terminal.h lldb/source/Host/common/Terminal.cpp lldb/source/Plugins/Scri

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState [WIP]

mgorny updated this revision to Diff 375908. mgorny retitled this revision from "[lldb] [Host] Merge TerminalState into Terminal" to "[lldb] [Host] Refactor TerminalState [WIP]". mgorny edited the summary of this revision. mgorny added a comment. Ok, let's start with smaller refactoring and see w