[Lldb-commits] [PATCH] D110721: [lldb] [Host] Merge TerminalState into Terminal

2021-09-29 Thread Michał Górny via Phabricator via lldb-commits
mgorny added inline comments. Comment at: lldb/source/Host/common/Terminal.cpp:124 if (save_process_group) - m_process_group = ::tcgetpgrp(0); else I think passing `0` here was a mistake. The `Restore()` method passed `fd` instead. =

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Merge TerminalState into Terminal

2021-09-29 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, teemperor, emaste, krytarowski. mgorny requested review of this revision. Merge the routines from the TerminalState class into Terminal. There does not seem to be a real advantage from having the two classes split, and the TerminalStat