This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9449f441fc9b: gn build: Add support for building LLDB on
Linux. (authored by pcc).
Changed prior to commit:
https://reviews.llvm.org/D109463?vs=37
thakis added a comment.
(Please watch http://45.33.8.238/ when landing this :) )
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109463/new/
https://reviews.llvm.org/D109463
___
lldb-commits mailing list
l
thakis added inline comments.
Comment at: llvm/utils/gn/secondary/BUILD.gn:15
"//lld/test",
+"//lldb",
"//llvm/test",
pcc wrote:
> thakis wrote:
> > pcc wrote:
> > > thakis wrote:
> > > > Does this build fine on windows?
> > > >
> > > > Generally t
pcc added inline comments.
Comment at: llvm/utils/gn/secondary/BUILD.gn:15
"//lld/test",
+"//lldb",
"//llvm/test",
thakis wrote:
> pcc wrote:
> > thakis wrote:
> > > Does this build fine on windows?
> > >
> > > Generally this only depends on the te
thakis added inline comments.
Comment at: llvm/utils/gn/secondary/BUILD.gn:15
"//lld/test",
+"//lldb",
"//llvm/test",
pcc wrote:
> thakis wrote:
> > Does this build fine on windows?
> >
> > Generally this only depends on the test targets which in t
pcc updated this revision to Diff 371464.
pcc added a comment.
Move to data_deps
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109463/new/
https://reviews.llvm.org/D109463
Files:
llvm/utils/gn/secondary/BUILD.gn
llvm/utils/gn/secondary/lldb/in
pcc added inline comments.
Comment at: llvm/utils/gn/secondary/BUILD.gn:15
"//lld/test",
+"//lldb",
"//llvm/test",
thakis wrote:
> Does this build fine on windows?
>
> Generally this only depends on the test targets which in turn depend on the
> b
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Very cool. LG with top-level BUILD.gn comment addressed :)
Comment at: llvm/utils/gn/secondary/BUILD.gn:15
"//lld/test",
+"//lldb",
"//llvm/test",
-
pcc created this revision.
pcc added a reviewer: thakis.
Herald added a subscriber: emaste.
pcc requested review of this revision.
Herald added a project: LLVM.
On Linux, LLDB depends on lldb-server at runtime (is it different on
Mac?), so I created a top-level lldb target that will build both lld
