This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3f1372365ac6: [lldb] Support gdbserver signals (authored by
mgorny).
Herald added a project: LLDB.
Changed prior to commi
labath accepted this revision.
labath added inline comments.
Comment at:
lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py:486
+ lldb.eStopReasonSignal)
+# NB: this may need adjusting per current platform
+self.assertE
mgorny updated this revision to Diff 385917.
mgorny edited the summary of this revision.
mgorny added a comment.
Add fallback to `QThreadSuffixSupported` and a respective test. Improve the
summary.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108078/new/
https://reviews.llvm.org/D1080
labath added a comment.
It would be nice if the commit message/summary included more details about the
differences in signal handling (the things we talked about on irc), but
generally, I think this patch looks good.
The only thing that's missing is interoperability with older lldb-compatible
mgorny updated this revision to Diff 371011.
mgorny marked an inline comment as done.
mgorny added a comment.
Rebased.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108078/new/
https://reviews.llvm.org/D108078
Files:
lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_tes
mgorny marked an inline comment as done.
mgorny added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1344
"qEcho+",
+ "native-signals+",
};
JDevlieghere wrote:
> What about `debugserver`,
mgorny updated this revision to Diff 367414.
mgorny added a comment.
Advertise `native-signals+` in debugserver too.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108078/new/
https://reviews.llvm.org/D108078
Files:
lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testc
JDevlieghere requested changes to this revision.
JDevlieghere added a comment.
This revision now requires changes to proceed.
Didn't mean to accept yet (originally I thought the native-signals check was
inverted)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108078/new/
https://reviews
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1344
"qEcho+",
+ "native-signals+",
};
mgorny updated this revision to Diff 366621.
mgorny retitled this revision from "[lldb] Support gdbserver signals [WIP]" to
"[lldb] Support gdbserver signals".
mgorny edited the summary of this revision.
mgorny added a comment.
Included all signals from `include/gdb/signals.def`.
CHANGES SINCE
mgorny updated this revision to Diff 366487.
mgorny edited the summary of this revision.
mgorny added a comment.
Added client tests for GDB and LLDB signal variants. Moved signal init into
`DidLaunchOrAttach`, in order to have normalized target triple already (needed
for correct os-name in test)
mgorny created this revision.
mgorny added reviewers: krytarowski, emaste, labath, jasonmolenda, JDevlieghere.
mgorny requested review of this revision.
Add support for the original gdbserver signal mapping when communicating
with GDB. If qSupported indicates that we are talking to LLDB (via
'nat
12 matches
Mail list logo
